-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full Expr
support to StochasticSwap
#10506
Conversation
This was mostly already there (and why I had missed problems when testing before), the missing piece was just for `switch` statements. This commit also adds some final tests of the pass.
One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is a straightforward fix. I assume you're saving the level 0 full path transpile()
tests for a separate PR with the other optimization levels.
Pull Request Test Coverage Report for Build 5671996471
💛 - Coveralls |
Yeah, I turned it up while writing full integration tests. I need to write a similar PR for testing Sabre (a minor bug in all switch handling), and then that's everything working. I'll try and do it late this evening. |
This was mostly already there (and why I had missed problems when testing before), the missing piece was just for `switch` statements. This commit also adds some final tests of the pass. (cherry picked from commit 7af335e)
This was mostly already there (and why I had missed problems when testing before), the missing piece was just for `switch` statements. This commit also adds some final tests of the pass. (cherry picked from commit 7af335e) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
This was mostly already there (and why I had missed problems when testing before), the missing piece was just for `switch` statements. This commit also adds some final tests of the pass.
Summary
This was mostly already there (and why I had missed problems when testing before), the missing piece was just for
switch
statements. This commit also adds some final tests of the pass.Details and comments
Changelog from #10331.